From 3dcc59112308211b6ac8478a4ad997ed3f17d9b1 Mon Sep 17 00:00:00 2001 From: Jordan Harband Date: Wed, 5 Aug 2020 22:04:10 -0700 Subject: [PATCH 001/155] [eslint config] [base] add `id-denylist` rule --- packages/eslint-config-airbnb-base/rules/style.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/packages/eslint-config-airbnb-base/rules/style.js b/packages/eslint-config-airbnb-base/rules/style.js index 05f687171e..8403ebb75b 100644 --- a/packages/eslint-config-airbnb-base/rules/style.js +++ b/packages/eslint-config-airbnb-base/rules/style.js @@ -107,8 +107,13 @@ module.exports = { // Blacklist certain identifiers to prevent them being used // https://eslint.org/docs/rules/id-blacklist + // TODO: semver-major, remove once eslint v7.4+ is required 'id-blacklist': 'off', + // disallow specified identifiers + // https://eslint.org/docs/rules/id-denylist + 'id-denylist': 'off', + // this option enforces minimum and maximum identifier lengths // (variable names, property names etc.) 'id-length': 'off', From 973384be1b4ec2c58c5d9ba113a54a10cb757b96 Mon Sep 17 00:00:00 2001 From: Jordan Harband Date: Wed, 5 Aug 2020 22:06:20 -0700 Subject: [PATCH 002/155] [eslint config] [*] [dev deps] update `@babel/runtime`, `eslint-find-rules`, `eslint-plugin-jsx-a11y`, `eslint-plugin-react` --- packages/eslint-config-airbnb-base/package.json | 4 ++-- packages/eslint-config-airbnb/package.json | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/eslint-config-airbnb-base/package.json b/packages/eslint-config-airbnb-base/package.json index 146b7d5035..7bb31343e5 100644 --- a/packages/eslint-config-airbnb-base/package.json +++ b/packages/eslint-config-airbnb-base/package.json @@ -53,12 +53,12 @@ }, "homepage": "https://github.com/airbnb/javascript", "devDependencies": { - "@babel/runtime": "^7.8.7", + "@babel/runtime": "^7.11.2", "babel-preset-airbnb": "^4.5.0", "babel-tape-runner": "^3.0.0", "eclint": "^2.8.1", "eslint": "^5.16.0 || ^6.8.0 || ^7.2.0", - "eslint-find-rules": "^3.5.0", + "eslint-find-rules": "^3.6.0", "eslint-plugin-import": "^2.22.0", "in-publish": "^2.0.1", "safe-publish-latest": "^1.1.4", diff --git a/packages/eslint-config-airbnb/package.json b/packages/eslint-config-airbnb/package.json index 02c702ca76..105b3811a6 100644 --- a/packages/eslint-config-airbnb/package.json +++ b/packages/eslint-config-airbnb/package.json @@ -59,15 +59,15 @@ "object.entries": "^1.1.2" }, "devDependencies": { - "@babel/runtime": "^7.8.7", + "@babel/runtime": "^7.11.2", "babel-preset-airbnb": "^4.5.0", "babel-tape-runner": "^3.0.0", "eclint": "^2.8.1", "eslint": "^5.16.0 || ^6.8.0 || ^7.2.0", - "eslint-find-rules": "^3.5.0", + "eslint-find-rules": "^3.6.0", "eslint-plugin-import": "^2.22.0", - "eslint-plugin-jsx-a11y": "^6.3.0", - "eslint-plugin-react": "^7.20.0", + "eslint-plugin-jsx-a11y": "^6.3.1", + "eslint-plugin-react": "^7.20.5", "eslint-plugin-react-hooks": "^4 || ^3 || ^2.3.0 || ^1.7.0", "in-publish": "^2.0.1", "react": ">= 0.13.0", From 1dc71d38395633f9f9099614765bd4361c9a9c64 Mon Sep 17 00:00:00 2001 From: Jordan Harband Date: Mon, 3 Aug 2020 09:36:24 -0700 Subject: [PATCH 003/155] [guide] [react] add missing PascalCase guidance for prop names --- react/README.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/react/README.md b/react/README.md index 99518e5a75..d964d17a30 100644 --- a/react/README.md +++ b/react/README.md @@ -267,7 +267,7 @@ This style guide is mostly based on the standards that are currently prevalent i ## Props - - Always use camelCase for prop names. + - Always use camelCase for prop names, or PascalCase if the prop value is a React component. ```jsx // bad @@ -280,6 +280,7 @@ This style guide is mostly based on the standards that are currently prevalent i ``` From a24dc34a4a2748c99006a48e997aa0a06b1d4d94 Mon Sep 17 00:00:00 2001 From: Akshath Sivaprasad Date: Wed, 5 Aug 2020 21:38:20 -0700 Subject: [PATCH 004/155] [guide] [react] Add examples for formatting multiline conditional components --- react/README.md | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/react/README.md b/react/README.md index d964d17a30..4811ddaf70 100644 --- a/react/README.md +++ b/react/README.md @@ -214,6 +214,27 @@ This style guide is mostly based on the standards that are currently prevalent i // good {showButton &&