-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Labels
needs-triageIssue that require triageIssue that require triage
Description
Is there an existing issue for this?
- I have searched the existing issues
Current Behavior
During workspace startup, app buttons (VS Code, Cursor, Terminal, custom apps) appear clickable while the agent is still in "connecting" state, such as when the k8s pod is still spinning up. Clicking them fails because the agent hasn't established its connection yet. This creates a confusing UX.
Relevant Log Output
Expected Behavior
Before the agent connects, the Terminal/VS Code buttons should be disabled.
AgentRow.tsx (lines 67-69)
const shouldDisplayAgentApps = (agent.status === "connected" && hasAppsToDisplay) ||
(agent.status === "connecting" && !isExternalAgent);
AppLink.tsx
canClick defaults to true and only checks agent.lifecycle_state but NOT agent.status. These are different:
status: connecting | connected | disconnected | timeout (connection state)
lifecycle_state: created | starting | ready | etc. (startup script state)
Steps to Reproduce
- Create a k8s template following https://registry.coder.com/templates/coder/kubernetes
- Create a workspace with a large container image (takes several minutes to pull)
- App buttons (Cursor, VS Code, Terminal, etc.) appear clickable
- Click any button - connection fails
- Wait for agent to connect - buttons turn grey momentarily
- Wait for startup script to complete - buttons become clickable again and they work now
Environment
- Host OS: Ubuntu 24.04
- Coder version: v2.29.3
Additional Context
No response
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
needs-triageIssue that require triageIssue that require triage