fix: replace confetti with dialog for license upgrade confirmation#22089
Draft
blinkagent[bot] wants to merge 3 commits intomainfrom
Draft
fix: replace confetti with dialog for license upgrade confirmation#22089blinkagent[bot] wants to merge 3 commits intomainfrom
blinkagent[bot] wants to merge 3 commits intomainfrom
Conversation
Removes the react-confetti animation and replaces it with a proper Dialog component for the license upgrade success screen. The dialog uses the existing Dialog component (Radix-based) with: - A placeholder icon (SparklesIcon) for the Blink animation - Title and description text - A "Get started" dismiss button - Faded overlay background The Blink animation asset (6th brand ident from coder.com/brand) should be added as a follow-up once the SVG/Rive file is committed to the repo. Fixes #22088
Adds the Blink ident SVG animation (6th brand ident) to the license upgrade success dialog, replacing the SparklesIcon placeholder. The animation is committed as a static asset at /blink-ident.svg for airgapped environment compatibility.
Cleans up the unused react-confetti package and useWindowSize hook that were only used by the now-replaced confetti animation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the confetti animation with a proper Dialog component for the license upgrade success screen.
Changes
react-confettiusage from the license settings pageLicenseUpgradeSuccessDialogcomponent using the existing Radix-basedDialogDialog includes:
Follow-up needed:
react-confettifrompackage.jsonif no longer used elsewhereFixes #22088
Created on behalf of @christin