From 73e4ddec1b725cf3e624e927a5da55feaf80e0ba Mon Sep 17 00:00:00 2001 From: Danny Chiao Date: Sun, 6 Mar 2022 03:55:46 -0500 Subject: [PATCH 1/2] fix: Fix default feast apply path without any extras (#2373) * fix: Fix default feast apply path without any extras Signed-off-by: Danny Chiao * revert removing ge Signed-off-by: Danny Chiao --- docs/reference/data-sources/spark.md | 12 +++++++++--- sdk/python/feast/__init__.py | 4 ---- sdk/python/feast/feature_store.py | 2 -- sdk/python/feast/inference.py | 7 ++++--- 4 files changed, 13 insertions(+), 12 deletions(-) diff --git a/docs/reference/data-sources/spark.md b/docs/reference/data-sources/spark.md index 25b69c7355e..d0bc495924c 100644 --- a/docs/reference/data-sources/spark.md +++ b/docs/reference/data-sources/spark.md @@ -13,7 +13,9 @@ The spark data source API allows for the retrieval of historical feature values Using a table reference from SparkSession(for example, either in memory or a Hive Metastore) ```python -from feast import SparkSource +from feast.infra.offline_stores.contrib.spark_offline_store.spark_source import ( + SparkSource, +) my_spark_source = SparkSource( table="FEATURE_TABLE", @@ -23,7 +25,9 @@ my_spark_source = SparkSource( Using a query ```python -from feast import SparkSource +from feast.infra.offline_stores.contrib.spark_offline_store.spark_source import ( + SparkSource, +) my_spark_source = SparkSource( query="SELECT timestamp as ts, created, f1, f2 " @@ -34,7 +38,9 @@ my_spark_source = SparkSource( Using a file reference ```python -from feast import SparkSource +from feast.infra.offline_stores.contrib.spark_offline_store.spark_source import ( + SparkSource, +) my_spark_source = SparkSource( path=f"{CURRENT_DIR}/data/driver_hourly_stats", diff --git a/sdk/python/feast/__init__.py b/sdk/python/feast/__init__.py index 0af226aa056..83b504b0cb9 100644 --- a/sdk/python/feast/__init__.py +++ b/sdk/python/feast/__init__.py @@ -3,9 +3,6 @@ from pkg_resources import DistributionNotFound, get_distribution from feast.infra.offline_stores.bigquery_source import BigQuerySource -from feast.infra.offline_stores.contrib.spark_offline_store.spark_source import ( - SparkSource, -) from feast.infra.offline_stores.file_source import FileSource from feast.infra.offline_stores.redshift_source import RedshiftSource from feast.infra.offline_stores.snowflake_source import SnowflakeSource @@ -50,5 +47,4 @@ "RedshiftSource", "RequestFeatureView", "SnowflakeSource", - "SparkSource", ] diff --git a/sdk/python/feast/feature_store.py b/sdk/python/feast/feature_store.py index 89e4df1d5fc..19741bcf127 100644 --- a/sdk/python/feast/feature_store.py +++ b/sdk/python/feast/feature_store.py @@ -42,7 +42,6 @@ from feast.data_source import DataSource from feast.diff.infra_diff import InfraDiff, diff_infra_protos from feast.diff.registry_diff import RegistryDiff, apply_diff_to_registry, diff_between -from feast.dqm.profilers.ge_profiler import GEProfiler from feast.entity import Entity from feast.errors import ( EntityNotFoundException, @@ -881,7 +880,6 @@ def create_saved_dataset( storage: SavedDatasetStorage, tags: Optional[Dict[str, str]] = None, feature_service: Optional[FeatureService] = None, - profiler: Optional[GEProfiler] = None, ) -> SavedDataset: """ Execute provided retrieval job and persist its outcome in given storage. diff --git a/sdk/python/feast/inference.py b/sdk/python/feast/inference.py index d233631d3da..b3e51b48162 100644 --- a/sdk/python/feast/inference.py +++ b/sdk/python/feast/inference.py @@ -8,7 +8,6 @@ FileSource, RedshiftSource, SnowflakeSource, - SparkSource, ) from feast.data_source import DataSource, RequestDataSource from feast.errors import RegistryInferenceFailure @@ -87,8 +86,10 @@ def update_data_sources_with_inferred_event_timestamp_col( ): # prepare right match pattern for data source ts_column_type_regex_pattern = "" - if isinstance(data_source, FileSource) or isinstance( - data_source, SparkSource + # TODO(adchia): Move Spark source inference out of this logic + if ( + isinstance(data_source, FileSource) + or "SparkSource" == data_source.__class__.__name__ ): ts_column_type_regex_pattern = r"^timestamp" elif isinstance(data_source, BigQuerySource): From 7eb430a412c83dc3713c13e8b837ccaf91ed24f1 Mon Sep 17 00:00:00 2001 From: feast-ci-bot Date: Sun, 6 Mar 2022 09:11:06 +0000 Subject: [PATCH 2/2] chore(release): release 0.19.2 ## [0.19.2](https://github.com/feast-dev/feast/compare/v0.19.1...v0.19.2) (2022-03-06) ### Bug Fixes * Fix default feast apply path without any extras ([#2373](https://github.com/feast-dev/feast/issues/2373)) ([73e4dde](https://github.com/feast-dev/feast/commit/73e4ddec1b725cf3e624e927a5da55feaf80e0ba)) --- CHANGELOG.md | 7 +++++++ infra/charts/feast-python-server/Chart.yaml | 2 +- infra/charts/feast-python-server/README.md | 2 +- infra/charts/feast/Chart.yaml | 2 +- infra/charts/feast/README.md | 6 +++--- infra/charts/feast/charts/feature-server/Chart.yaml | 4 ++-- infra/charts/feast/charts/feature-server/README.md | 4 ++-- infra/charts/feast/charts/feature-server/values.yaml | 2 +- .../charts/feast/charts/transformation-service/Chart.yaml | 4 ++-- infra/charts/feast/charts/transformation-service/README.md | 4 ++-- .../charts/feast/charts/transformation-service/values.yaml | 2 +- infra/charts/feast/requirements.yaml | 4 ++-- java/pom.xml | 2 +- 13 files changed, 26 insertions(+), 19 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4636c8a25c4..8f24eefbb04 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,12 @@ # Changelog +## [0.19.2](https://github.com/feast-dev/feast/compare/v0.19.1...v0.19.2) (2022-03-06) + + +### Bug Fixes + +* Fix default feast apply path without any extras ([#2373](https://github.com/feast-dev/feast/issues/2373)) ([73e4dde](https://github.com/feast-dev/feast/commit/73e4ddec1b725cf3e624e927a5da55feaf80e0ba)) + ## [0.19.1](https://github.com/feast-dev/feast/compare/v0.19.0...v0.19.1) (2022-03-05) diff --git a/infra/charts/feast-python-server/Chart.yaml b/infra/charts/feast-python-server/Chart.yaml index 8764ed36160..43cdb031c72 100644 --- a/infra/charts/feast-python-server/Chart.yaml +++ b/infra/charts/feast-python-server/Chart.yaml @@ -2,7 +2,7 @@ apiVersion: v2 name: feast-python-server description: Feast Feature Server in Python type: application -version: 0.19.1 +version: 0.19.2 keywords: - machine learning - big data diff --git a/infra/charts/feast-python-server/README.md b/infra/charts/feast-python-server/README.md index a03a91771f6..cd2e6652e47 100644 --- a/infra/charts/feast-python-server/README.md +++ b/infra/charts/feast-python-server/README.md @@ -1,6 +1,6 @@ # feast-python-server -![Version: 0.19.1](https://img.shields.io/badge/Version-0.19.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) +![Version: 0.19.2](https://img.shields.io/badge/Version-0.19.2-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) Feast Feature Server in Python diff --git a/infra/charts/feast/Chart.yaml b/infra/charts/feast/Chart.yaml index a9043c83206..3514855cf1f 100644 --- a/infra/charts/feast/Chart.yaml +++ b/infra/charts/feast/Chart.yaml @@ -1,7 +1,7 @@ apiVersion: v1 description: Feature store for machine learning name: feast -version: 0.19.1 +version: 0.19.2 keywords: - machine learning - big data diff --git a/infra/charts/feast/README.md b/infra/charts/feast/README.md index 1ea15c21827..10c4457ab49 100644 --- a/infra/charts/feast/README.md +++ b/infra/charts/feast/README.md @@ -8,7 +8,7 @@ This repo contains Helm charts for Feast components that are being installed on ## Chart: Feast -Feature store for machine learning Current chart version is `0.19.1` +Feature store for machine learning Current chart version is `0.19.2` ## Installation @@ -55,8 +55,8 @@ For more details, please see: https://docs.feast.dev/how-to-guides/running-feast | Repository | Name | Version | |------------|------|---------| | https://charts.helm.sh/stable | redis | 10.5.6 | -| https://feast-helm-charts.storage.googleapis.com | feature-server(feature-server) | 0.19.1 | -| https://feast-helm-charts.storage.googleapis.com | transformation-service(transformation-service) | 0.19.1 | +| https://feast-helm-charts.storage.googleapis.com | feature-server(feature-server) | 0.19.2 | +| https://feast-helm-charts.storage.googleapis.com | transformation-service(transformation-service) | 0.19.2 | ## Values diff --git a/infra/charts/feast/charts/feature-server/Chart.yaml b/infra/charts/feast/charts/feature-server/Chart.yaml index 2e553fe9a7e..8a90ec3de5c 100644 --- a/infra/charts/feast/charts/feature-server/Chart.yaml +++ b/infra/charts/feast/charts/feature-server/Chart.yaml @@ -1,8 +1,8 @@ apiVersion: v1 description: "Feast Feature Server: Online feature serving service for Feast" name: feature-server -version: 0.19.1 -appVersion: v0.19.1 +version: 0.19.2 +appVersion: v0.19.2 keywords: - machine learning - big data diff --git a/infra/charts/feast/charts/feature-server/README.md b/infra/charts/feast/charts/feature-server/README.md index d6aac9b6534..3dca0248a71 100644 --- a/infra/charts/feast/charts/feature-server/README.md +++ b/infra/charts/feast/charts/feature-server/README.md @@ -1,6 +1,6 @@ # feature-server -![Version: 0.19.1](https://img.shields.io/badge/Version-0.19.1-informational?style=flat-square) ![AppVersion: v0.19.1](https://img.shields.io/badge/AppVersion-v0.19.1-informational?style=flat-square) +![Version: 0.19.2](https://img.shields.io/badge/Version-0.19.2-informational?style=flat-square) ![AppVersion: v0.19.2](https://img.shields.io/badge/AppVersion-v0.19.2-informational?style=flat-square) Feast Feature Server: Online feature serving service for Feast @@ -17,7 +17,7 @@ Feast Feature Server: Online feature serving service for Feast | envOverrides | object | `{}` | Extra environment variables to set | | image.pullPolicy | string | `"IfNotPresent"` | Image pull policy | | image.repository | string | `"feastdev/feature-server-java"` | Docker image for Feature Server repository | -| image.tag | string | `"0.19.1"` | Image tag | +| image.tag | string | `"0.19.2"` | Image tag | | ingress.grpc.annotations | object | `{}` | Extra annotations for the ingress | | ingress.grpc.auth.enabled | bool | `false` | Flag to enable auth | | ingress.grpc.class | string | `"nginx"` | Which ingress controller to use | diff --git a/infra/charts/feast/charts/feature-server/values.yaml b/infra/charts/feast/charts/feature-server/values.yaml index 0b4f5028c23..be27b2e39c1 100644 --- a/infra/charts/feast/charts/feature-server/values.yaml +++ b/infra/charts/feast/charts/feature-server/values.yaml @@ -5,7 +5,7 @@ image: # image.repository -- Docker image for Feature Server repository repository: feastdev/feature-server-java # image.tag -- Image tag - tag: 0.19.1 + tag: 0.19.2 # image.pullPolicy -- Image pull policy pullPolicy: IfNotPresent diff --git a/infra/charts/feast/charts/transformation-service/Chart.yaml b/infra/charts/feast/charts/transformation-service/Chart.yaml index b14527c72ca..291e192da1a 100644 --- a/infra/charts/feast/charts/transformation-service/Chart.yaml +++ b/infra/charts/feast/charts/transformation-service/Chart.yaml @@ -1,8 +1,8 @@ apiVersion: v1 description: "Transformation service: to compute on-demand features" name: transformation-service -version: 0.19.1 -appVersion: v0.19.1 +version: 0.19.2 +appVersion: v0.19.2 keywords: - machine learning - big data diff --git a/infra/charts/feast/charts/transformation-service/README.md b/infra/charts/feast/charts/transformation-service/README.md index c1d36de2e3a..547a87e5284 100644 --- a/infra/charts/feast/charts/transformation-service/README.md +++ b/infra/charts/feast/charts/transformation-service/README.md @@ -1,6 +1,6 @@ # transformation-service -![Version: 0.19.1](https://img.shields.io/badge/Version-0.19.1-informational?style=flat-square) ![AppVersion: v0.19.1](https://img.shields.io/badge/AppVersion-v0.19.1-informational?style=flat-square) +![Version: 0.19.2](https://img.shields.io/badge/Version-0.19.2-informational?style=flat-square) ![AppVersion: v0.19.2](https://img.shields.io/badge/AppVersion-v0.19.2-informational?style=flat-square) Transformation service: to compute on-demand features @@ -13,7 +13,7 @@ Transformation service: to compute on-demand features | envOverrides | object | `{}` | Extra environment variables to set | | image.pullPolicy | string | `"IfNotPresent"` | Image pull policy | | image.repository | string | `"feastdev/feature-transformation-server"` | Docker image for Transformation Server repository | -| image.tag | string | `"0.19.1"` | Image tag | +| image.tag | string | `"0.19.2"` | Image tag | | nodeSelector | object | `{}` | Node labels for pod assignment | | podLabels | object | `{}` | Labels to be added to Feast Serving pods | | replicaCount | int | `1` | Number of pods that will be created | diff --git a/infra/charts/feast/charts/transformation-service/values.yaml b/infra/charts/feast/charts/transformation-service/values.yaml index f8f84d9ce42..fdf0230fbd0 100644 --- a/infra/charts/feast/charts/transformation-service/values.yaml +++ b/infra/charts/feast/charts/transformation-service/values.yaml @@ -5,7 +5,7 @@ image: # image.repository -- Docker image for Transformation Server repository repository: feastdev/feature-transformation-server # image.tag -- Image tag - tag: 0.19.1 + tag: 0.19.2 # image.pullPolicy -- Image pull policy pullPolicy: IfNotPresent diff --git a/infra/charts/feast/requirements.yaml b/infra/charts/feast/requirements.yaml index 7e075ae9005..9ec5ab221c1 100644 --- a/infra/charts/feast/requirements.yaml +++ b/infra/charts/feast/requirements.yaml @@ -1,12 +1,12 @@ dependencies: - name: feature-server alias: feature-server - version: 0.19.1 + version: 0.19.2 condition: feature-server.enabled repository: https://feast-helm-charts.storage.googleapis.com - name: transformation-service alias: transformation-service - version: 0.19.1 + version: 0.19.2 condition: transformation-service.enabled repository: https://feast-helm-charts.storage.googleapis.com - name: redis diff --git a/java/pom.xml b/java/pom.xml index 0398b7c077f..3bfa939ac48 100644 --- a/java/pom.xml +++ b/java/pom.xml @@ -38,7 +38,7 @@ - 0.19.1 + 0.19.2 https://github.com/feast-dev/feast UTF-8