Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: python-zeroconf/python-zeroconf
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: jgrill/python-zeroconf
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Dec 1, 2014

  1. encode strings to utf-8 in ServiceInfo 

    I found that properties dict values registered as "False" rather than the intended string value, such as "path" in the provided examples.

eg.

Service Paul's Test Web Site._http._tcp.local. added
  Type is _http._tcp.local.
  Address is 10.0.1.2:80
  Weight is 0, Priority is 0
  Server is ash-2.local.
  Properties are
    path: False
    @jgrill
    jgrill committed Dec 1, 2014
    Configuration menu
    Copy the full SHA
    c2f05f1 View commit details
    Browse the repository at this point in the history
Loading