lib: convert to arrow function

horihiro · targos · commit 6f42b98a1a62 · 2018-11-28T16:33:34.000+01:00
PR-URL: #24623 Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com>
diff --git a/lib/internal/child_process.js b/lib/internal/child_process.js
@@ -68,32 +68,32 @@ const handleConversion = {
   'net.Native': {
     simultaneousAccepts: true,
 
-    send: function(message, handle, options) {
+    send(message, handle, options) {
       return handle;
     },
 
-    got: function(message, handle, emit) {
+    got(message, handle, emit) {
       emit(handle);
     }
   },
 
   'net.Server': {
     simultaneousAccepts: true,
 
-    send: function(message, server, options) {
+    send(message, server, options) {
       return server._handle;
     },
 
-    got: function(message, handle, emit) {
+    got(message, handle, emit) {
       var server = new net.Server();
-      server.listen(handle, function() {
+      server.listen(handle, () => {
         emit(server);
       });
     }
   },
 
   'net.Socket': {
-    send: function(message, socket, options) {
+    send(message, socket, options) {
       if (!socket._handle)
         return;
 
@@ -141,7 +141,7 @@ const handleConversion = {
       return handle;
     },
 
-    postSend: function(message, handle, options, callback, target) {
+    postSend(message, handle, options, callback, target) {
       // Store the handle after successfully sending it, so it can be closed
       // when the NODE_HANDLE_ACK is received. If the handle could not be sent,
       // just close it.
@@ -159,7 +159,7 @@ const handleConversion = {
       }
     },
 
-    got: function(message, handle, emit) {
+    got(message, handle, emit) {
       var socket = new net.Socket({
         handle: handle,
         readable: true,
@@ -183,28 +183,28 @@ const handleConversion = {
   'dgram.Native': {
     simultaneousAccepts: false,
 
-    send: function(message, handle, options) {
+    send(message, handle, options) {
       return handle;
     },
 
-    got: function(message, handle, emit) {
+    got(message, handle, emit) {
       emit(handle);
     }
   },
 
   'dgram.Socket': {
     simultaneousAccepts: false,
 
-    send: function(message, socket, options) {
+    send(message, socket, options) {
       message.dgramType = socket.type;
 
       return socket[kStateSymbol].handle;
     },
 
-    got: function(message, handle, emit) {
+    got(message, handle, emit) {
       var socket = new dgram.Socket(message.dgramType);
 
-      socket.bind(handle, function() {
+      socket.bind(handle, () => {
         emit(socket);
       });
     }
@@ -618,7 +618,7 @@ function setupChannel(target, channel) {
     }
 
     // Convert handle object
-    obj.got.call(this, message, handle, function(handle) {
+    obj.got.call(this, message, handle, (handle) => {
       handleMessage(message.msg, handle, isInternal(message.msg));
     });
   });
@@ -740,7 +740,7 @@ function setupChannel(target, channel) {
       }
 
       if (wasAsyncWrite) {
-        req.oncomplete = function() {
+        req.oncomplete = () => {
           control.unref();
           if (typeof callback === 'function')
             callback(null);
@@ -877,7 +877,7 @@ function _validateStdio(stdio, sync) {
 
   // Translate stdio into C++-readable form
   // (i.e. PipeWraps or fds)
-  stdio = stdio.reduce(function(acc, stdio, i) {
+  stdio = stdio.reduce((acc, stdio, i) => {
     function cleanup() {
       for (var i = 0; i < acc.length; i++) {
         if ((acc[i].type === 'pipe' || acc[i].type === 'ipc') && acc[i].handle)
