gh-113174: Sync with importlib_metadata 7.0#113175
Conversation
Will there be docs changes in this PR or another? |
I've added docs in b610b6d. I chose not to mention some of the changes as they seemed incidental enough not to affect most users. |
hugovk
left a comment
There was a problem hiding this comment.
Would this also benefit from an entry in What's New in Python 3.13?
5914c78 to
aa23e5a
Compare
Perhaps. I'd consider mentioning the |
AlexWaygood
left a comment
There was a problem hiding this comment.
I agree with @hugovk that the removal of EntryPoint.__getitem__ should be mentioned in "What's New". It doesn't need to be a prominent mention near the top of the document, but we should try to make sure that all backwards-incompatible changes are mentioned somewhere in that document, in my opinion.
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
|
Today I learned about the syntax (docs). The exclamation point means to ignore EntryPoint because it isn't documented. |
|
Thanks for the review. Merging, but happy to revisit if needed. |
* Sync with importlib_metadata 7.0.0 * Add blurb * Update docs to reflect changes. * Link datamodel docs for object.__getitem__ Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com> * Add what's new for removed __getattr__ * Link datamodel docs for object.__getitem__ Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com> * Add exclamation point, as that seems to be used for other classes. --------- Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
|
There's some tests that are failing on Windows for this change. The build that introduced the failure is the one with this PR merged: |
|
I worked around the problem by enabling SeCreateSymbolicLinkPrivilege for the buildbot user, but ultimately I believe the test should be skipped for users without this privilege set. |
* Sync with importlib_metadata 7.0.0 * Add blurb * Update docs to reflect changes. * Link datamodel docs for object.__getitem__ Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com> * Add what's new for removed __getattr__ * Link datamodel docs for object.__getitem__ Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com> * Add exclamation point, as that seems to be used for other classes. --------- Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
* Sync with importlib_metadata 7.0.0 * Add blurb * Update docs to reflect changes. * Link datamodel docs for object.__getitem__ Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com> * Add what's new for removed __getattr__ * Link datamodel docs for object.__getitem__ Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com> * Add exclamation point, as that seems to be used for other classes. --------- Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
* Sync with importlib_metadata 7.0.0 * Add blurb * Update docs to reflect changes. * Link datamodel docs for object.__getitem__ Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com> * Add what's new for removed __getattr__ * Link datamodel docs for object.__getitem__ Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com> * Add exclamation point, as that seems to be used for other classes. --------- Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Uh oh!
There was an error while loading. Please reload this page.