Merged
Conversation
…and libraries; enhance tracing in TracedRunnable to include input and output in span updates.
…uster setup script with ingress-nginx installation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Standardizes ingress controller from Bitnami to the official ingress-nginx chart, aligns local cluster setup with that change, and refines Docker build contexts to reduce unnecessary file transfer and improve build cleanliness.
- Replaces Bitnami nginx-ingress-controller Helm dependency with official ingress-nginx (chart + image tag pin).
- Refactors k3d setup script for idempotency, robustness, and to install the official ingress-nginx controller.
- Consolidates and expands Docker build ignore patterns to reduce build context size.
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 10 comments.
| File | Description |
|---|---|
| infrastructure/server-setup/base-setup/Chart.yaml | Swaps Helm dependency to official ingress-nginx and updates description. |
| infrastructure/server-setup/base-setup/values.yaml | Pins ingress-nginx controller image tag. |
| infrastructure/local-cluster-setup/setup-k3d-cluster.sh | Refactors cluster setup and installs/updates ingress-nginx via Helm with version + image overrides. |
| Tiltfile | Adjusts docker_build ignore patterns to exclude frontend sources or noisy subdirectories. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…t installation process
…late into fix/bitnami-issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the development and deployment setup to standardize on the official Kubernetes
ingress-nginxcontroller instead of the Bitnaminginx-ingress-controller, and improves Docker build configuration by refining ignored files and directories in the build context. The changes also enhance the local cluster setup script for better reliability and clarity.Helm chart and ingress controller standardization:
base-setup/Chart.yamlfrom Bitnami'snginx-ingress-controllerto the officialingress-nginxchart, and updated the description accordingly.base-setup/values.yamlto pin theingress-nginxcontroller image tag tov1.13.3, ensuring consistency with the setup script.Local cluster setup improvements:
setup-k3d-cluster.shto:ingress-nginxHelm chart (instead of Bitnami).Docker build context refinements:
docker_buildcalls inTiltfileto ignore the entireservices/frontend/directory (instead of just.nx/andtmp/), reducing unnecessary files in backend and admin/extractor images. [1] [2] [3] [4]services/frontend/.nx/,services/frontend/tmp/, andservices/frontend/node_modules/for cleaner image builds. [1] [2]