Skip to content

ref(core): rename gen_ai.input.messages.original_length to sentry.sdk_meta.gen_ai.input.messages.original_length#18970

Merged
nicohrubec merged 1 commit intodevelopfrom
nh/record-non-truncated-message-length
Jan 26, 2026
Merged

ref(core): rename gen_ai.input.messages.original_length to sentry.sdk_meta.gen_ai.input.messages.original_length#18970
nicohrubec merged 1 commit intodevelopfrom
nh/record-non-truncated-message-length

Conversation

@nicohrubec
Copy link
Member

@nicohrubec nicohrubec commented Jan 26, 2026

  • renames the attribute
  • sets the attribute to 1 if the input is a string
  • adds more explicit checks for this attribute in the node integration tests (mostly for truncation tests to verify this works as expected)

Closes #18918

@nicohrubec nicohrubec changed the title ref(core): rename gen_ai.input.messages.original_length to sentry.sdk_meta.gen_ai.input.messages.original_length ref(core): rename gen_ai.input.messages.original_length to sentry.sdk_meta.gen_ai.input.messages.original_length Jan 26, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 26, 2026

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 9,122 - 9,102 +0%
GET With Sentry 1,765 19% 1,700 +4%
GET With Sentry (error only) 6,070 67% 6,128 -1%
POST Baseline 1,217 - 1,209 +1%
POST With Sentry 608 50% 578 +5%
POST With Sentry (error only) 1,046 86% 1,040 +1%
MYSQL Baseline 3,300 - 3,271 +1%
MYSQL With Sentry 488 15% 409 +19%
MYSQL With Sentry (error only) 2,688 81% 2,637 +2%

View base workflow run

@nicohrubec nicohrubec marked this pull request as ready for review January 26, 2026 10:10
@nicohrubec nicohrubec requested a review from RulaKhaled January 26, 2026 10:10
@nicohrubec nicohrubec merged commit 0e597c2 into develop Jan 26, 2026
413 of 416 checks passed
@nicohrubec nicohrubec deleted the nh/record-non-truncated-message-length branch January 26, 2026 12:45
@github-actions github-actions bot mentioned this pull request Jan 27, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RulaKhaled RulaKhaled RulaKhaled approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Record non-truncated messages length

2 participants

@nicohrubec @RulaKhaled