Use client locale if possible in validation of incoming requests#3815
Merged
Use client locale if possible in validation of incoming requests#3815
Conversation
Contributor
Test Results 310 files 310 suites 48s ⏱️ Results for commit be802a9. ♻️ This comment has been updated with latest results. |
bbakerman
approved these changes
Feb 27, 2025
Member
Author
|
Let me add a test before merging in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3779 , thanks @replikonio for reporting!
This updates 2 validation rules to use the locale in the validation context. This locale is set as the client's locale (via ExecutionInput) or defaults to the JVM default locale.
One validation rule for incoming requests
VariableTypesMatchwas already using the client's locale. This updates 2 more rules to use the client's locale as well.