Conversation
…rom toSpecification
Contributor
Test Results 306 files 306 suites 47s ⏱️ Results for commit 9c04196. ♻️ This comment has been updated with latest results. |
…rom toSpecification - test fix up
bbakerman
commented
Feb 13, 2025
| * | ||
| * @return a new {@link ExecutionResult} from that map | ||
| */ | ||
| static ExecutionResult fromSpecification(Map<String, Object> specificationMap) { |
Member
Author
There was a problem hiding this comment.
naming is the opposite of toSpecification
bbakerman
commented
Feb 13, 2025
| * | ||
| * @return a {@link GraphQLError} | ||
| */ | ||
| static GraphQLError fromSpecification(Map<String, Object> specificationMap) { |
Member
Author
There was a problem hiding this comment.
naming is the opposite of toSpecification
Member
Author
There was a problem hiding this comment.
impl in internal class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can today make a Map<String,Object> from an ExecutionResult but we can do the opposite
I needed to to this in some client reading HTTP graphql response code and making a ER was difficult and should be in graphql-java so here it is