Skip to content

Comments

Fixed graphql.execution.UnknownOperationExceptionso that it does not escape#3826

Merged
bbakerman merged 2 commits intomasterfrom
fixed-unknown-operation-as-error
Feb 17, 2025
Merged

Fixed graphql.execution.UnknownOperationExceptionso that it does not escape#3826
bbakerman merged 2 commits intomasterfrom
fixed-unknown-operation-as-error

Conversation

@bbakerman
Copy link
Member

graphql.execution.UnknownOperationException used to come as out as a runtime exception - it should be a graphql error

This was reported by the Spring team as suprising and it is.

@bbakerman bbakerman added this to the 23.x breaking changes milestone Feb 17, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2025

Test Results

  306 files    306 suites   47s ⏱️
3 489 tests 3 483 ✅ 6 💤 0 ❌
3 578 runs  3 572 ✅ 6 💤 0 ❌

Results for commit d7d29b2.

♻️ This comment has been updated with latest results.

}

def "document with two operations but no specified operation throws"() {
def "document with two operations but no specified operation does not throw"() {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change in behavior - no longer throwing an exception

Copy link
Member

@dondonz dondonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this is better than patching in Spring

@bbakerman bbakerman merged commit 6669c20 into master Feb 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants