Fixed graphql.execution.UnknownOperationExceptionso that it does not escape#3826
Merged
Fixed graphql.execution.UnknownOperationExceptionso that it does not escape#3826
Conversation
Contributor
Test Results 306 files 306 suites 47s ⏱️ Results for commit d7d29b2. ♻️ This comment has been updated with latest results. |
bbakerman
commented
Feb 17, 2025
| } | ||
|
|
||
| def "document with two operations but no specified operation throws"() { | ||
| def "document with two operations but no specified operation does not throw"() { |
Member
Author
There was a problem hiding this comment.
change in behavior - no longer throwing an exception
dondonz
approved these changes
Feb 17, 2025
Member
dondonz
left a comment
There was a problem hiding this comment.
Thanks this is better than patching in Spring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
graphql.execution.UnknownOperationException used to come as out as a runtime exception - it should be a graphql error
This was reported by the Spring team as suprising and it is.