Merged
Conversation
…ther than master commits
Contributor
Test Results 311 files 311 suites 46s ⏱️ Results for commit 57487ae. |
andimarek
reviewed
Apr 3, 2025
| push: | ||
| pull_request: | ||
| types: | ||
| - closed |
Member
There was a problem hiding this comment.
Closed, but not merged? Or does close mean merged here?
Member
Author
There was a problem hiding this comment.
There is no specific "merged" event. See the documentation, I thought "closed" would be the closest to what we want https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#pull_request
andimarek
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 2 problems seen lately on our performance pipeline, after enabling multiple concurrent runs
git pullbefore committing results. Example of race condition: https://github.com/graphql-java/graphql-java/actions/runs/14025083675/job/39262341170