refactor engine tracking and simplify it#3893
Merged
Conversation
Contributor
Test Results 313 files 313 suites 53s ⏱️ Results for commit 59195c1. ♻️ This comment has been updated with latest results. |
bbakerman
reviewed
Apr 6, 2025
bbakerman
reviewed
Apr 6, 2025
| // allow instrumentation to tweak the result | ||
| executionResult = executionResult.thenCompose(result -> instrumentation.instrumentExecutionResult(result, instrumentationParameters, instrumentationState)); | ||
| return executionResult; | ||
| return instrumentation.instrumentExecutionResult(abortException.toExecutionResult(), instrumentationParameters, instrumentationState); |
bbakerman
reviewed
Apr 6, 2025
bbakerman
requested changes
Apr 6, 2025
Member
bbakerman
left a comment
There was a problem hiding this comment.
I approve generally but some code to be cleaned up
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simplifies the engine tracking:
We really only need to take care of CF that are externally contributed to the engine and the sync code in start. This means we don't need most call/run code, but rather need to handle the CF returned by DataFetcher or instrumentation correctly.
Also: this changes the code to have zero impact when no EngineStateObserver is registered.