Specify nullness for some graphql.schema.idl classes#3895
Specify nullness for some graphql.schema.idl classes#3895dondonz merged 3 commits intographql-java:masterfrom
graphql.schema.idl classes#3895Conversation
bbakerman
left a comment
There was a problem hiding this comment.
Lets decide on the Assert nullness question and then move forward
|
I am geenrally happy with this PR so thank you. Its just that Assert is a special case and I am not sure how to move forward on that |
|
Thanks for the pull request! I like your choice with Assert as well |
dondonz
left a comment
There was a problem hiding this comment.
Thanks for the PR! We are on Easter break, will come back to your PR after the holidays
|
@bbakerman as discussed, the changes you suggested were implemented so merging in |
|
I think method parameters in the Without that, null safety checks will fail because those method arguments are nullable by nature. The contract annotation lets JSpecify know that once it's checked, it cannot be null. One last piece of feedback: adding |
Related #3878
I applied
@NullMarkedon the classes:graphql.Assertgraphql.schema.idl.FieldWiringEnvironmentgraphql.schema.idl.InterfaceWiringEnvironmentgraphql.schema.idl.ScalarInfographql.schema.idl.ScalarWiringEnvironmentgraphql.schema.idl.SchemaParsergraphql.schema.idl.TypeDefinitionRegistrygraphql.schema.idl.UnionWiringEnvironmentgraphql.schema.idl.WiringEnvironment