Fix FpKit.concat parameters#4154
Merged
bbakerman merged 1 commit intographql-java:masterfrom Oct 26, 2025
Merged
Conversation
Make FpKit.concat parameters contravariant, so that it can be used in more call-sites; update a few such places that didn't work before in various Definition classes.
Contributor
Author
|
Note: FpKit has this issue with several other methods, can be fixed in a follow up if deemed necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make FpKit.concat parameters contravariant, so that it can be used in more call-sites; update a few such places that didn't work before in various Definition classes.