Allow pluggable conditional node support#3223
Merged
Conversation
dondonz
approved these changes
May 23, 2023
Member
dondonz
left a comment
There was a problem hiding this comment.
Looks good! If you're mega keen you could add more test cases for fragments etc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates a callback mechanism that supports conditional node inclusion using mechanisms beyond the standard
@skip / @includeA
ConditionalNodeDecisioninstance must be included in the graphql context and this is then used during conditional node support code to make a custom decision.This will allowing something like
And then on the back end the value of the feature flag can be securely checked (say to a FF service like LaunchDarkly say) to see if the field should be included or not
@skipis driven by the client - this allows field exclusion / inclusion driven by the serverSee #1811