removed synchronised from code base as much as possible for VT#3317
Merged
removed synchronised from code base as much as possible for VT#3317
Conversation
He-Pin
approved these changes
Sep 2, 2023
| */ | ||
| public void addError(GraphQLError error, ResultPath fieldPath) { | ||
| synchronized (this) { | ||
| errorsLock.runLocked(() -> { |
There was a problem hiding this comment.
I like this kind of change, diff is small
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is sort of a POC but perhaps it can just be our approach to locking key structures
synchronisedis simple but Loom does not like ithttps://softwaremill.com/what-is-blocking-in-loom/
related also to quarkusio/quarkus#35605 (comment)