Skip to content

Switch to a data_files based install#104

Merged
blink1073 merged 8 commits intomasterfrom
include-kernel
Oct 9, 2017
Merged

Switch to a data_files based install#104
blink1073 merged 8 commits intomasterfrom
include-kernel

Conversation

@blink1073
Copy link
Contributor

@blink1073 blink1073 commented Oct 6, 2017

Automatically install the kernel when installing the package. Fixes #103 .

@dsblank
Copy link
Member

dsblank commented Oct 9, 2017

Thanks for this! I'll use it as an example for the other kernels.

@dsblank
Copy link
Member

dsblank commented Oct 9, 2017

BTW, what effect was the libedit change for?

@blink1073
Copy link
Contributor Author

There is a conflicting dependency between it and the octave conda package, opened an issue there.

@blink1073
Copy link
Contributor Author

I think I'd still like to have the advanced option of installing the kernel to a different spot if that makes more sense for the user, so they can remove our installed kernelspec and python -m octave_kernel install --user, so there's a bit of work left to do in this PR.

@blink1073 blink1073 merged commit ff24c33 into master Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants