Fix float narrowing tests in locales other than en-US#680
Merged
ClearScriptLib merged 1 commit intoClearFoundry:masterfrom Oct 8, 2025
Merged
Conversation
jerrys-msft
approved these changes
Oct 8, 2025
Collaborator
|
Thanks, @AnsisMalins! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
String.Format, by default, takes into account the current locale. In these tests, the result was being compared to a constant string that uses point as the decimal separator and commas as the thousands separators. Computers set to other languages would use different symbols for this, and tests would fail.
The alternative way to fix these tests would be to supply the en-US (or invariant) culture to the script being evaluated.