Skip to content

.NET 5.0 support and remove EOL .NET Core 3.0#125

Merged
batzen merged 13 commits intodevelopfrom
features/netcoreapp50
Dec 13, 2020
Merged

.NET 5.0 support and remove EOL .NET Core 3.0#125
batzen merged 13 commits intodevelopfrom
features/netcoreapp50

Conversation

@punker76
Copy link
Member

@punker76 punker76 commented Jul 16, 2020

  • .NET 5.0 support
  • Remove EOL .NET Core 3.0
  • Fix empty RECT in MonitorInfo (.NET 5 preview 7)
  • Removing unused interop code
  • Fixing or suppressing all newly introduced compiler warnings
  • AD0001: Disabled because it throws an NRE
  • Removing deprecated security attributes

@punker76 punker76 added this to the 4.x.x milestone Jul 16, 2020
@batzen
Copy link
Member

batzen commented Jul 22, 2020

RollForward only applies if the specified sdk version is not installed. Just increase the sdk version to 5 😉

@punker76 punker76 force-pushed the features/netcoreapp50 branch 9 times, most recently from 6d58db6 to ea9f248 Compare July 25, 2020 19:56
@punker76 punker76 force-pushed the features/netcoreapp50 branch from ea9f248 to 44e0188 Compare August 5, 2020 09:35
@FreddyDgh
Copy link

@punker76 I realize the .NET 5.0 work may not be completed yet, but are there any plans to release an updated NuGet package prior to the final .NET 5.0 release? In particular, the bug where simply maximizing a window throws an exception is particularly annoying.

I tried out the code in the features/netcoreapp50 branch, and that appeared to fix it, but having an updated NuGet package (maybe a preview version) would be really nice.

@punker76 punker76 force-pushed the features/netcoreapp50 branch from 9483efe to cb2c3f1 Compare October 31, 2020 22:19
@punker76 punker76 force-pushed the features/netcoreapp50 branch from 46b79ec to e026ed6 Compare November 24, 2020 22:55
Set version to 5.0.0
@punker76 punker76 force-pushed the features/netcoreapp50 branch from e026ed6 to 3abfa1a Compare November 24, 2020 23:03
@punker76 punker76 removed the Feature label Nov 24, 2020
@punker76 punker76 modified the milestones: 4.x.x, 5.0.0 Nov 24, 2020
@punker76 punker76 changed the title WIP .NET 5.0 .NET 5.0 support and remove EOL .NET Core 3.0 Nov 24, 2020
@punker76 punker76 requested a review from batzen November 24, 2020 23:17
@punker76
Copy link
Member Author

@batzen Can we publish this? WDYT

@batzen
Copy link
Member

batzen commented Nov 29, 2020

@punker76 LGTM

@batzen batzen merged commit 12b2012 into develop Dec 13, 2020
@punker76 punker76 deleted the features/netcoreapp50 branch December 18, 2020 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants