Use env var to build with system SQLite#100
Draft
chromatic wants to merge 1 commit intoDBD-SQLite:masterfrom
Draft
Use env var to build with system SQLite#100chromatic wants to merge 1 commit intoDBD-SQLite:masterfrom
chromatic wants to merge 1 commit intoDBD-SQLite:masterfrom
Conversation
I'm proposing this change for discussion. While our build system does have a patching mechanism, it's easier to specify environment variables than to carry patches between versions. The behavior here is essentially the same in both cases, but this approach gives other folks another mechanism to link against a non-bundled SQLite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm proposing this change for discussion. While our build system does have a patching mechanism, it's easier to specify environment variables than to carry patches between versions. The behavior here is essentially the same in both cases, but this approach gives other folks another mechanism to link against a non-bundled SQLite.