Build FANS as a library to be coupled to a macro-scale simulation via preCICE and the Micro Manager#23
Merged
IshaanDesai merged 136 commits intodevelopfrom Nov 4, 2024
Merged
Conversation
…ommand for GNU math lib
ignore before)
…tained FANS container
…n and update readme accordingly.
…uces size from 495MB to 161MB). Also add dev deps to dev package explicitly. And update docker.yaml workflow
…i-bin to runtime deps
…cmake in install step
…t's not supported there and erraneously add include paths called COMPONENT
siggmo
suggested changes
Oct 31, 2024
Contributor
siggmo
left a comment
There was a problem hiding this comment.
Some minor improvements regarding CMake.
Co-authored-by: Moritz Sigg <50019904+siggmo@users.noreply.github.com>
juliusgh
requested changes
Nov 3, 2024
sanathkeshav
reviewed
Nov 4, 2024
sanathkeshav
reviewed
Nov 4, 2024
sanathkeshav
reviewed
Nov 4, 2024
sanathkeshav
reviewed
Nov 4, 2024
sanathkeshav
reviewed
Nov 4, 2024
sanathkeshav
requested changes
Nov 4, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a multiscale simulation, FANS would be coupled to a macro-scale simulation. This coupling will be done using preCICE and the Micro Manager. For such a coupling, FANS needs to be compiled as a library with a pre-defined API. This API is described in https://precice.org/tooling-micro-manager-prepare-micro-simulation.html
This PR adds functionality for FANS to be coupled as a library. The original contribution is done by @tjwsch.