The LS1 PR: Introduce system for checking compiler flags: avx2 & fma#34
Merged
siggmo merged 5 commits intoDataAnalyticsEngineering:developfrom Dec 3, 2024
Merged
Conversation
Member
claudiushaag
commented
Nov 1, 2024
- i7-2600 was otherwise not able to built
- super backward change
- does not apply/test on macos
+ i7-2600 was otherwise not able to built + super backward change + does not apply/test on macos
siggmo
suggested changes
Nov 4, 2024
Contributor
siggmo
left a comment
There was a problem hiding this comment.
LGTM. Two minor suggestions.
Thanks a lot for adding this!
siggmo
approved these changes
Dec 2, 2024
Contributor
siggmo
left a comment
There was a problem hiding this comment.
Let's merge.
PS. there's a typo in LSCU_OUTPUT
CMakeLists.txt
Outdated
| target_compile_options(FANS_FANS PUBLIC -mavx2 -mfma) | ||
| elseif (CMAKE_SYSTEM_NAME STREQUAL "Linux") | ||
| # Linux: Check for AVX2 support using lscpu | ||
| execute_process(COMMAND lscpu OUTPUT_VARIABLE LSCU_OUTPUT ERROR_QUIET) |
Contributor
There was a problem hiding this comment.
typo: missing P in LSCU_OUTPUT
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.