Merged
Conversation
IshaanDesai
reviewed
May 5, 2025
Collaborator
IshaanDesai
left a comment
There was a problem hiding this comment.
The tests are extensive 👍 But most tests call fucntionality from the dashboard, rather than functions from FANS itself. We could move the tests into the dashboard folder as it would make sense to have them there.
6 tasks
claudiushaag
reviewed
May 5, 2025
claudiushaag
approved these changes
May 5, 2025
IshaanDesai
approved these changes
May 5, 2025
Member
Author
|
Before merging, I think we should super quickly integrate the pytest into the build and test CI (for Linux & MacOS) |
… set up in the Action workflow
IshaanDesai
reviewed
May 9, 2025
Collaborator
IshaanDesai
left a comment
There was a problem hiding this comment.
I went over the test/README. I have some suggestions.
Co-authored-by: Ishaan Desai <ishaandesai@gmail.com>
Co-authored-by: Ishaan Desai <ishaandesai@gmail.com>
Co-authored-by: Ishaan Desai <ishaandesai@gmail.com>
Co-authored-by: Ishaan Desai <ishaandesai@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_displacement_averaging- This test verifies that the average of displacement fluctuations is zero .test_homogenization_consistency- This test verifies that the relationship stress_average = homogenized_tangent * strain_average holds.test_homogenized_tangent_spd- This test verifies that the homogenized tangent is strictly Symmetric Positive Definitetest_homogenized_tangent_within_VRbounds- This test verifies that the homogenized tangent is within Voigt and Reuss bounds for linear elastic and thermal problems.test_loading_to_strain_average- This test verifies that the strain_average field in the results matches the macroscale_loading specified in the input JSON file.test_strain_stress_averaging- This test verifies that the average of strain/stress fields matches the strain_average/stress_average in the results.test_Conversion- Test various conversions, e.g., Full tensor <-> Mandel, Mandel <-> Voigt (both orderings)test_Ciso- test the isotropic projection for 4-tensors using randomized data.test_kappaiso- test the isotropic projection for 2-tensors using randomized data.