Skip to content

Include json via CMake#87

Merged
sanathkeshav merged 4 commits intodevelopfrom
feature-include-json
Sep 26, 2025
Merged

Include json via CMake#87
sanathkeshav merged 4 commits intodevelopfrom
feature-include-json

Conversation

@sanathkeshav
Copy link
Member

@sanathkeshav sanathkeshav commented Sep 26, 2025 •
edited
Loading

This PR includes nlohmann-json as a dependency in the CMake file instead of including the header manually as before.

Checklist:

  • I made sure that the CI passed before I ask for a review.
  • I added a summary of the changes (compared to the last release) in the CHANGELOG.md.
  • If necessary, I made changes to the documentation and/or added new content.
  • I will remember to squash-and-merge, providing a useful summary of the changes of this PR.

@sanathkeshav sanathkeshav changed the title use find_package Include json via CMake Sep 26, 2025
@sanathkeshav sanathkeshav marked this pull request as ready for review September 26, 2025 13:28
@sanathkeshav sanathkeshav mentioned this pull request Sep 26, 2025
Merged
5 tasks
IshaanDesai
IshaanDesai approved these changes Sep 26, 2025
View reviewed changes
Copy link
Collaborator

@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great that there is finally an alternative to shipping the JSON header file.

@sanathkeshav sanathkeshav merged commit 036bcf9 into develop Sep 26, 2025
9 checks passed
@sanathkeshav sanathkeshav deleted the feature-include-json branch September 26, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IshaanDesai IshaanDesai IshaanDesai approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sanathkeshav @IshaanDesai