Skip to content

[@types/node] extends stream.Transform in crypto#37945

Merged
rbuckton merged 1 commit intoDefinitelyTyped:masterfrom
trivikr:crypto-extends-stream-Transform
Aug 30, 2019
Merged

[@types/node] extends stream.Transform in crypto#37945
rbuckton merged 1 commit intoDefinitelyTyped:masterfrom
trivikr:crypto-extends-stream-Transform

Conversation

@trivikr
Copy link
Contributor

@trivikr trivikr commented Aug 27, 2019

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

@trivikr trivikr mentioned this pull request Aug 27, 2019
Merged
2 tasks
@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Awaiting reviewer feedback labels Aug 27, 2019
@typescript-bot
Copy link
Contributor

typescript-bot commented Aug 27, 2019 •
edited
Loading

@trivikr Thank you for submitting this PR!

🔔 @microsoft @DefinitelyTyped @jkomyno @a-tarasyuk @alvis @r3nya @btoueg @BrunoScheufler @smac89 @tellnes @Touffy @DeividasBakanas @eyqs @Flarna @Hannes-Magnusson-CK @KSXGitHub @hoo29 @kjin @ajafff @islishude @mwiktorczyk @matthieusieben @mohsen1 @n-e @octo-sniffle @parambirs @eps1lon @SimonSchick @ThomasdenH @WilcoBakker @wwwy3y3 @ZaneHannanAU @samuela @kuehlein @j-oliveras @bhongy @chyzwar @jeremiergz @ivansieder - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

Flarna
Flarna approved these changes Aug 27, 2019
View reviewed changes
Copy link
Contributor

@Flarna Flarna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe verify this via a test but it's not that obvious to verify inheritence.

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Merge:Express and removed Awaiting reviewer feedback labels Aug 27, 2019
@typescript-bot
Copy link
Contributor

typescript-bot commented Aug 27, 2019

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@rbuckton rbuckton merged commit 51381d5 into DefinitelyTyped:master Aug 30, 2019
@typescript-bot
Copy link
Contributor

typescript-bot commented Aug 30, 2019

I just published @types/node@12.7.3 to npm.

@typescript-bot
Copy link
Contributor

typescript-bot commented Aug 30, 2019

I just published @types/node@11.13.20 to npm.

@typescript-bot
Copy link
Contributor

typescript-bot commented Aug 30, 2019

I just published @types/node@10.14.17 to npm.

@typescript-bot
Copy link
Contributor

typescript-bot commented Aug 30, 2019

I just published @types/node@8.10.53 to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Flarna Flarna Flarna approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@trivikr @typescript-bot @Flarna @rbuckton