[@types/node]: v24.12.0#74607
Conversation
|
@kshitijanurag Thank you for submitting this PR! This is a live comment that I will keep updated. 1 package in this PR
Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 74607,
"author": "kshitijanurag",
"headCommitOid": "f9ad15001b94504fb307d530be7d8ba5a6e658bb",
"mergeBaseOid": "6d0fd0d6183bbde47f641c69ffe87c9cc0e422c7",
"lastPushDate": "2026-02-28T18:22:35.000Z",
"lastActivityDate": "2026-03-02T17:44:13.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "node",
"kind": "edit",
"files": [
{
"path": "types/node/v24/child_process.d.ts",
"kind": "definition"
},
{
"path": "types/node/v24/crypto.d.ts",
"kind": "definition"
},
{
"path": "types/node/v24/http.d.ts",
"kind": "definition"
},
{
"path": "types/node/v24/https.d.ts",
"kind": "definition"
},
{
"path": "types/node/v24/module.d.ts",
"kind": "definition"
},
{
"path": "types/node/v24/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/node/v24/perf_hooks.d.ts",
"kind": "definition"
},
{
"path": "types/node/v24/process.d.ts",
"kind": "definition"
},
{
"path": "types/node/v24/sqlite.d.ts",
"kind": "definition"
},
{
"path": "types/node/v24/test/http.ts",
"kind": "test"
},
{
"path": "types/node/v24/test/module.ts",
"kind": "test"
},
{
"path": "types/node/v24/test/perf_hooks.ts",
"kind": "test"
},
{
"path": "types/node/v24/test/sqlite.ts",
"kind": "test"
},
{
"path": "types/node/v24/test/util.ts",
"kind": "test"
},
{
"path": "types/node/v24/test/v8.ts",
"kind": "test"
},
{
"path": "types/node/v24/util.d.ts",
"kind": "definition"
},
{
"path": "types/node/v24/v8.d.ts",
"kind": "definition"
},
{
"path": "types/node/v24/worker_threads.d.ts",
"kind": "definition"
}
],
"owners": [
"Microsoft",
"jkomyno",
"r3nya",
"btoueg",
"touffy",
"mohsen1",
"galkin",
"eps1lon",
"WilcoBakker",
"chyzwar",
"trivikr",
"yoursunny",
"qwelias",
"ExE-Boss",
"peterblazejewicz",
"addaleax",
"victorperin",
"NodeJS",
"LinusU",
"wafuwafu13",
"mcollina",
"Semigradsky",
"Renegade334",
"anonrig"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "Renegade334",
"date": "2026-03-02T17:44:13.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 3977536439,
"ciResult": "pass"
} |
|
🔔 @microsoft @jkomyno @r3nya @btoueg @Touffy @mohsen1 @galkin @eps1lon @WilcoBakker @chyzwar @trivikr @yoursunny @qwelias @ExE-Boss @peterblazejewicz @addaleax @victorperin @nodejs @LinusU @wafuwafu13 @mcollina @Semigradsky @Renegade334 @anonrig — please review this PR in the next few days. Be sure to explicitly select |
|
@kshitijanurag The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review. |
016313f to
d0c23f7
Compare
|
@kshitijanurag The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review. |
0f7cf00 to
c302dcf
Compare
Got it |
|
@Renegade334 Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
dae594a to
6e1a87c
Compare
Renegade334
left a comment
There was a problem hiding this comment.
Please bump the package version.
|
@kshitijanurag One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
3cb60c0 to
89121ea
Compare
021b9d5 to
f9ad150
Compare
|
@Renegade334 Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
Please fill in this template.
Update types for Node.js
v24.12.0pnpm test node.package.json.