fix: prevent closing EditMessageForm on non-sbumit button click#2884
Merged
MartinCupela merged 1 commit intomasterfrom Nov 17, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2884 +/- ##
==========================================
- Coverage 81.56% 81.49% -0.07%
==========================================
Files 499 499
Lines 10112 10112
Branches 2312 2312
==========================================
- Hits 8248 8241 -7
- Misses 1743 1750 +7
Partials 121 121 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Size Change: +79 B (+0.01%) Total Size: 1.18 MB
ℹ️ View Unchanged
|
oliverlaz
approved these changes
Nov 14, 2025
|
🎉 This PR is included in version 13.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Prevent closing EditMessageForm on non-sbumit button click
Closes REACT-650
🛠 Implementation details
Edit form was closed when clicking on the audio play button. Just in case I have added
type='button'to buttons that remove an attachment in the form.🎨 UI Changes
Add relevant screenshots