Skip to content

fix: prevent increasing unread count by useMarkRead hook if read-events are disabled#2925

Merged
MartinCupela merged 1 commit intomasterfrom
fix/useMarkRead/noop-on-missing-read-events
Jan 29, 2026
Merged

fix: prevent increasing unread count by useMarkRead hook if read-events are disabled#2925
MartinCupela merged 1 commit intomasterfrom
fix/useMarkRead/noop-on-missing-read-events

Conversation

@MartinCupela
Copy link
Contributor

🎯 Goal

Prevent increasing local unread count for the unread indicators on message.new events if read-events are disabled in channel configuration.

This leads to prevention of floating unread notification indicators display.

@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.94%. Comparing base (f4675c6) to head (6ded3ad).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2925      +/-   ##
==========================================
- Coverage   80.06%   79.94%   -0.13%     
==========================================
  Files         511      511              
  Lines       10788    10803      +15     
  Branches     2709     2711       +2     
==========================================
- Hits         8637     8636       -1     
- Misses       1898     1914      +16     
  Partials      253      253              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

Size Change: +14 B (0%)

Total Size: 290 kB

Filename Size Change
./dist/cjs/index.js 166 kB +14 B (+0.01%)
ℹ️ View Unchanged
Filename Size
./dist/audioProcessing-BbOs2wMd.js 1.32 kB
./dist/Channel-pqo4jV1s.js 24.4 kB
./dist/ChannelPreview-BNyNO58P.js 17.8 kB
./dist/cjs/emojis.js 3.29 kB
./dist/cjs/experimental.js 5.8 kB
./dist/cjs/mp3-encoder.js 1.27 kB
./dist/css/index.css 6.16 kB
./dist/css/v2/emoji-mart.css 1.84 kB
./dist/css/v2/emoji-replacement.css 300 B
./dist/css/v2/index.css 39.4 kB
./dist/css/v2/index.layout.css 22.8 kB
./dist/MessageInputContext-Buw2XInb.js 314 B

compressed-size-action

@MartinCupela MartinCupela merged commit d0e7b5f into master Jan 29, 2026
7 checks passed
@MartinCupela MartinCupela deleted the fix/useMarkRead/noop-on-missing-read-events branch January 29, 2026 11:26
MartinCupela added a commit that referenced this pull request Jan 29, 2026
github-actions bot pushed a commit that referenced this pull request Jan 29, 2026
## [13.13.5](v13.13.4...v13.13.5) (2026-01-29)

### Bug Fixes

* prevent increasing unread count by useMarkRead hook if read-events are disabled ([#2925](#2925)) ([3f4b876](3f4b876))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments