Skip to content

update to latest#1

Merged
xiaohuilam merged 12 commits intoKeymatician:mainfrom
themesberg:main
Apr 23, 2023
Merged

update to latest#1
xiaohuilam merged 12 commits intoKeymatician:mainfrom
themesberg:main

Conversation

@xiaohuilam
Copy link

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change contains documentation update

Breaking changes

Please document the breaking changes if suitable.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

AlfieJones and others added 12 commits March 29, 2023 15:28
Fixes #607

Co-authored-by: Ricardo Lüders <ricardo@luders.com.br>
* fix: group list styling

* fix: borders between list group items

---------

Co-authored-by: Mees van Dongen <mvandongen@ilionx.com>
Co-authored-by: Ricardo Lüders <ricardo@luders.com.br>
* Update default.ts

* Update Table.tsx

* Update TableBody.tsx

* Update TableCell.tsx

* Update TableRow.tsx

* Update defaults.ts

* Fix prettier errors
fix(component/models): prevent body scrolling
…700)

* Prevent scrolling of body when modal is shown

Fixes #604

* fix(component/model): prevent scrolling of body
…ss == 0 (#698)

* fix: group list styling (#668)

* fix: group list styling

* fix: borders between list group items

---------

Co-authored-by: Mees van Dongen <mvandongen@ilionx.com>
Co-authored-by: Ricardo Lüders <ricardo@luders.com.br>

* fix(progress.tsx): progress bar shows labels even when it is disabled at progress value is 0

The conditional rendring using the '&&' would return 0 on condition being false which would get
displayed when progress value is 0. This was fixed using ternary operator instead. And also the
label would get hidden at low progress values which is now fixed.

fix #696

* style(default.ts): changed progress bar label(inside label) color for light mode

* fix(components/progressbar): fix progressbar showing label when progress == 0

---------

Co-authored-by: Mees van Dongen <mvandongen@ilionx.com>
Co-authored-by: Ricardo Lüders <ricardo@luders.com.br>
fix: cypress:run broken command fixed by cypress.config and file naming convention update

Co-authored-by: Ricardo Lüders <ricardo@luders.com.br>
…535)

* refactor(component): simplify the usage of spinner inside the Button component

re #175

* refactor(components/button): changes on theme and spinner usage

---------

Co-authored-by: Ricardo Lüders <rluders@redhat.com>
… accordion tests (#705)

* fix(accordion.tsx): fixed bug where Accordion.Content would not close after being opened

Accordion content can now be closed and opened leaving all items collapsed.

#618

* style(accordion.tsx): update spacing after adding toggleOpen function

* test(accordion.spec.tsx): add tests for accordion click to toggle

#684

* style(accordion.spec): prettier

* style(accordion.tsx): change conditional to ternary for toggleOpen

* style(accordion.tsx): prettier update for cloneElement format

---------

Co-authored-by: Adrian Apodaca <aapodaca@shroodbi.com>
* feat(sidebar): allow to customize the Sidebar component with 'as'

In some cases, the sidebar is the main navigation of an app and setting using

    <Sidebar as="nav">
       ...
    </Sidebar>

would be more appropriate.

* fix(sidebar): prefer 'nav' as the component of sidebars
@xiaohuilam xiaohuilam merged commit 4549d91 into Keymatician:main Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants