Fix UI display issues and improve macOS Tahoe/Sequoia support#1827
Open
arsarsars1 wants to merge 2 commits intoMonitorControl:mainfrom
Open
Fix UI display issues and improve macOS Tahoe/Sequoia support#1827arsarsars1 wants to merge 2 commits intoMonitorControl:mainfrom
arsarsars1 wants to merge 2 commits intoMonitorControl:mainfrom
Conversation
- **Menu Bar Slider**: - Redesigned layout to column style (icon above slider). - Aligned icon to left-start. - Increased vertical spacing and view height for better touch target and aesthetics. - Fixed icon vs slider overlap issues. - **Preferences UI**: - **Displays**: Fixed truncated friendly name text field, increased height, and improved vertical alignment. - **About**: Fixed truncated app name text. - **Keyboard**: Improved layout of accessibility troubleshooting buttons (Help/Reset), added container/label for better grid alignment. - **macOS Tahoe Support**: - Added accessibility permission reset functionality. - Implemented Custom HUD fallback for cases where native OSD is broken.
Member
|
Hi @arsarsars1, thank you for the pull request, I really appreciate it. I am not sure I am entirely comfortable with the new menu layout, having the icons above the slider looks kind-of Strange (if we'd like to follow Tahoe style, maybe a min/max icon at both end of the slider might be better. Also, the super-small knob feels a bit strange:
Regarding the OSD, it might need some things to iron out. There seem to be white corners (beyond the rounding) and the yellow brightness icon does not seem to fully follow the macOS vibe.
Because of this, I am not yet ready to accept this PR just yet, but I leave it hanging here. But again, I appreciate your work, I just recommend iterating a bit on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Overview
This PR addresses UI display issues and improves macOS Tahoe (15.x) / Sequoia compatibility.
Changes Made
UI Fixes
Menu Bar Slider
Preferences - Displays Tab
Preferences - About Tab
Preferences - Keyboard Tab
macOS Tahoe/Sequoia Support
Accessibility Permission Reset
tccutil reset AccessibilityfunctionalityCustom HUD Fallback
OSDManagerfailsFiles Changed
Testing
Related Issues