v1 Color Temperature Control#1828
Open
claycantrell wants to merge 1 commit intoMonitorControl:mainfrom
Open
Conversation
Member
|
Hi there, thanks for creating this PR and contributing to improve the app! for some reason I get a As you mention, the solution is not yet complete. I recommend wiring everything in properly - and by default these features should be disabled (as many displays don't properly support it and many don't need it, so the app's simple basic brightness/contrast/volume focused profile should not change too much). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Color Temperature Control via DDC
Summary
How It Works
The color temperature control uses a simplified Kelvin-to-RGB approach:
This creates an asymmetric adjustment where blue changes more dramatically than red, mimicking real color temperature behavior.
Files Changed
MonitorControl/Enums/PrefKey.swiftshowColorTemperaturepreference keyMonitorControl/Support/MenuHandler.swiftMonitorControl/Support/SliderHandler.swiftvideoGainRed/videoGainBlueMonitorControl/View Controllers/Preferences/MenuslidersPrefsViewController.swiftMonitorControl/UI/Base.lproj/Main.storyboardMonitorControl/View Controllers/Preferences/DisplaysPrefsCellView.swiftMonitorControl/View Controllers/Preferences/DisplaysPrefsViewController.swiftMonitorControl/Model/OtherDisplay.swiftMonitorControl/UI/en.lproj/Localizable.stringsKnown Limitations