feat: support HMR in Angular apps by DimitarTachev · Pull Request #788 · NativeScript/nativescript-dev-webpack

DimitarTachev · 2019-02-05T09:40:46Z

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the [CLA].
All existing tests are passing: https://github.com/NativeScript/nativescript-dev-webpack/blob/master/CONTRIBUTING.md#testing-locally-by-running-e2e-tests
Tests for the changes are included.

…nippets using another AngularCompierPlugin transformer

…transformer conditions based on the input env options

…t tests

feat: support HMR in Angular project by inserting the required code s…

5bafd27

…nippets using another AngularCompierPlugin transformer

DimitarTachev requested review from sis0k0 and vakrilov and removed request for sis0k0 February 5, 2019 09:53

DimitarTachev mentioned this pull request Feb 5, 2019

chore: remove outdated warnings NativeScript/nativescript-cli#4337

Merged

5 tasks

DimitarTachev added 2 commits February 5, 2019 17:21

fix: fixed the Lazy transformer condition and add unit tests for all …

4ebf8ab

…transformer conditions based on the input env options

chore(ng-hmr-transformer): handle invalid main.ts content and add uni…

fc2f86b

…t tests

rosen-vladimirov approved these changes Feb 6, 2019

View reviewed changes

DimitarTachev merged commit 6a9ce33 into master Feb 6, 2019

DimitarTachev deleted the tachev/support-hmr-in-angular branch February 6, 2019 15:32

sis0k0 mentioned this pull request Feb 10, 2019

[Tracking] 🔥 Hot Module Replacement with webpack NativeScript/NativeScript#6398

Open

36 tasks