Added EVENT_ENGINE which is fired when a new engine socket is created.#166
Merged
mattqs merged 1 commit intoQuobject:masterfrom Jul 25, 2018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small change since the engine is already accessible via
socket.Io().EngineSocket. The key difference is that this new event exposes it before it's open allowing application code to use it to subscribe to events likeEVENT_TRANSPORTwhich opens a lot of doors.My particular use-case is a bit hacky but with this small change I'm able to get hold of the transport layer at application level and add support for the
Set-Cookieheader allowing us to deploy a SocketIO server behind an AWS load balancer with sticky sessions (based on cookies). GAME CHANGER!