Minor: remove TODO for json.get multi path support#1045
Open
mapleFU wants to merge 2 commits intoRedisJSON:masterfrom
Open
Minor: remove TODO for json.get multi path support#1045mapleFU wants to merge 2 commits intoRedisJSON:masterfrom
mapleFU wants to merge 2 commits intoRedisJSON:masterfrom
Conversation
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1045 +/- ##
=======================================
Coverage 79.18% 79.18%
=======================================
Files 15 15
Lines 3853 3853
=======================================
Hits 3051 3051
Misses 802 802 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I'm reading the code, I found there is a TODO for multi-path support in
JSON.GET. However, I found that it has already been supported. So I remove the TODO.