Don't call redis_key.get_value if no flag is given to JSON.SET#1153
Open
chkp-omris wants to merge 1 commit intoRedisJSON:masterfrom
Open
Don't call redis_key.get_value if no flag is given to JSON.SET#1153chkp-omris wants to merge 1 commit intoRedisJSON:masterfrom
chkp-omris wants to merge 1 commit intoRedisJSON:masterfrom
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed I'm having underwhelming performance for JSON.SET and tried digging a bit in the code.
I saw that regardless of whether the user used a NX/XX or not, RedisJSON still calls get_value but it's not used in case that no flags were given to JSON.SET (which is my use case)
MOD-6312