[DOC] JSON command edits by nermiller · Pull Request #846 · RedisJSON/RedisJSON

nermiller · 2022-10-29T05:43:00Z

Updates JSON commands and restructures sections

CLAassistant · 2022-10-29T05:43:05Z

All committers have signed the CLA.

codecov · 2022-10-29T06:04:07Z

Codecov Report

Base: 81.19% // Head: 81.19% // No change to project coverage 👍

Coverage data is based on head (564b1eb) compared to base (33de90f).
Patch has no changes to coverable lines.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #846   +/-   ##
=======================================
  Coverage   81.19%   81.19%           
=======================================
  Files          14       14           
  Lines        3871     3871           
=======================================
  Hits         3143     3143           
  Misses        728      728

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

nermiller · 2022-10-29T18:15:29Z

@oshadmi, please review. I've updated examples an restructured sections, adding Required and Optional Arguments. cc @banker

oshadmi

Looks great!
Some comments.

docs/commands/json.arrappend.md

docs/commands/json.arrindex.md

docs/commands/json.arrinsert.md

docs/commands/json.arrindex.md

docs/commands/json.arrinsert.md

docs/commands/json.arrpop.md

oshadmi

A few more comments 🙏🏼

docs/commands/json.arrpop.md

docs/commands/json.arrtrim.md

docs/commands/json.numincrby.md

docs/commands/json.resp.md

docs/commands/json.set.md

docs/commands/json.strappend.md

docs/commands/json.toggle.md

Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>

docs/commands/json.arrinsert.md

docs/commands/json.arrindex.md

Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>

docs/commands/json.arrinsert.md

docs/commands/json.arrpop.md

docs/commands/json.arrinsert.md

nermiller · 2022-11-10T05:18:27Z

@oshadmi, I believe I addressed most if not all of your comments. If there are any minor comments left, let's note and pick them up as we go. Please take another look. Thank you for persevering through this!

oshadmi

Few comments, last touch-up

docs/commands/json.arrappend.md

docs/commands/json.arrinsert.md

docs/commands/json.arrpop.md

docs/commands/json.arrtrim.md

Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>

oshadmi

👍🏼 👌🏼

* Partial fix for REDISIO-186: JSON broken links * Applied feedback from Chayim * Updates examples and restructures sections * Update docs/commands/json.arrappend.md Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com> * Update docs/commands/json.arrappend.md Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com> * Update docs/commands/json.arrindex.md Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com> * Update docs/commands/json.arrindex.md Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com> * Update docs/commands/json.arrinsert.md Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com> * Update docs/commands/json.arrindex.md Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com> * Update docs/commands/json.arrindex.md * Update docs/commands/json.arrinsert.md * Update docs/commands/json.arrlen.md Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com> * Update docs/commands/json.arrpop.md Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com> * Update docs/commands/json.arrtrim.md Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com> * Update docs/commands/json.numincrby.md Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com> * Update docs/commands/json.resp.md Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com> * Update docs/commands/json.set.md Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com> * Update docs/commands/json.strappend.md Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com> * Update docs/commands/json.toggle.md Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com> * Update docs/commands/json.arrpop.md * Update docs/commands/json.arrpop.md * Update docs/commands/json.arrinsert.md * Update json.arrtrim.md * Update docs/commands/json.arrappend.md Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com> * Update docs/commands/json.arrinsert.md Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com> * Update docs/commands/json.arrtrim.md Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com> * Update docs/commands/json.arrpop.md Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com> Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com> (cherry picked from commit 112a4fa)

nermiller and others added 8 commits May 19, 2022 10:44

Partial fix for REDISIO-186: JSON broken links

89d9b50

Merge branch 'master' into master

abe9242

Applied feedback from Chayim

b93ba70

Merge branch 'master' of https://github.com/nermiller/RedisJSON

20b2e92

Merge branch 'master' into master

228cfa7

Merge branch 'RedisJSON:master' into master

75f43c6

Merge branch 'RedisJSON:master' into master

ed0f4f7

Updates examples and restructures sections

9c9c611

Merge branch 'master' into json-command-edits

d5207fa

oshadmi reviewed Nov 3, 2022

View reviewed changes

oshadmi reviewed Nov 4, 2022

View reviewed changes

nermiller and others added 6 commits November 7, 2022 14:34

Update docs/commands/json.arrappend.md

d5c425b

Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>

Update docs/commands/json.arrappend.md

361e58a

Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>

Update docs/commands/json.arrindex.md

6ef4638

Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>

Update docs/commands/json.arrindex.md

34bd29b

Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>

Update docs/commands/json.arrinsert.md

3c37a64

Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>

Update docs/commands/json.arrindex.md

6917b22

Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>

nermiller commented Nov 7, 2022

View reviewed changes

docs/commands/json.arrinsert.md Outdated Show resolved Hide resolved

nermiller commented Nov 7, 2022

View reviewed changes

docs/commands/json.arrindex.md Outdated Show resolved Hide resolved

nermiller and others added 8 commits November 7, 2022 14:53

Update docs/commands/json.arrindex.md

4c88fc5

Update docs/commands/json.arrinsert.md

f40b9d9

Update docs/commands/json.arrlen.md

4f60c27

Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>

Update docs/commands/json.arrpop.md

1de0aca

Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>

Update docs/commands/json.arrtrim.md

4e1ae1d

Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>

Update docs/commands/json.numincrby.md

93cb491

Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>

Update docs/commands/json.resp.md

0d47cdf

Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>

Update docs/commands/json.set.md

fd0ac10

Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>

nermiller and others added 2 commits November 7, 2022 15:05

Update docs/commands/json.strappend.md

42c97d1

Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>

Update docs/commands/json.toggle.md

28dd011

Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>

nermiller commented Nov 7, 2022

View reviewed changes

docs/commands/json.arrinsert.md Outdated Show resolved Hide resolved

docs/commands/json.arrpop.md Outdated Show resolved Hide resolved

docs/commands/json.arrpop.md Outdated Show resolved Hide resolved

nermiller added 2 commits November 7, 2022 15:09

Update docs/commands/json.arrpop.md

fdb107d

Update docs/commands/json.arrpop.md

5339ee8

nermiller commented Nov 7, 2022

View reviewed changes

docs/commands/json.arrinsert.md Outdated Show resolved Hide resolved

nermiller added 2 commits November 7, 2022 15:23

Update docs/commands/json.arrinsert.md

9533a38

Update json.arrtrim.md

95736ca

nermiller requested a review from oshadmi November 10, 2022 05:16

oshadmi reviewed Nov 10, 2022

View reviewed changes

docs/commands/json.arrappend.md Outdated Show resolved Hide resolved

docs/commands/json.arrinsert.md Outdated Show resolved Hide resolved

docs/commands/json.arrpop.md Outdated Show resolved Hide resolved

docs/commands/json.arrtrim.md Outdated Show resolved Hide resolved

gkorland requested a review from oshadmi November 10, 2022 13:48

nermiller and others added 4 commits November 10, 2022 09:18

Update docs/commands/json.arrappend.md

2340356

Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>

Update docs/commands/json.arrinsert.md

7c6cebc

Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>

Update docs/commands/json.arrtrim.md

9a88738

Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>

Update docs/commands/json.arrpop.md

bc336b7

Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>

gkorland added the documentation label Nov 10, 2022

oshadmi approved these changes Nov 10, 2022

View reviewed changes

nermiller and others added 2 commits November 10, 2022 13:25

Merge branch 'master' into json-command-edits

eaa2e01

Merge branch 'master' into json-command-edits

564b1eb

oshadmi merged commit 112a4fa into RedisJSON:master Nov 14, 2022

Comments

Conversation

nermiller commented Oct 29, 2022

Uh oh!

CLAassistant commented Oct 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Oct 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nermiller commented Oct 29, 2022

Uh oh!

oshadmi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

oshadmi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nermiller commented Nov 10, 2022

Uh oh!

oshadmi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

oshadmi left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

CLAassistant commented Oct 29, 2022 •

edited

Loading

codecov bot commented Oct 29, 2022 •

edited

Loading