Skip to content

Comments

clean clippy warnings#847

Merged
gkorland merged 12 commits intomasterfrom
gkorland-clean-clippy-warnings
Dec 20, 2022
Merged

clean clippy warnings#847
gkorland merged 12 commits intomasterfrom
gkorland-clean-clippy-warnings

Conversation

@gkorland
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Base: 81.41% // Head: 81.45% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (2e33f74) compared to base (f43dfb8).
Patch coverage: 76.85% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #847      +/-   ##
==========================================
+ Coverage   81.41%   81.45%   +0.04%     
==========================================
  Files          14       14              
  Lines        3879     3872       -7     
==========================================
- Hits         3158     3154       -4     
+ Misses        721      718       -3     
Impacted Files Coverage Δ
src/array_index.rs 100.00% <ø> (ø)
src/c_api.rs 8.60% <0.00%> (+0.06%) ⬆️
src/jsonpath/select_value.rs 100.00% <ø> (ø)
src/jsonpath/json_path.rs 69.27% <46.15%> (+0.11%) ⬆️
src/jsonpath/json_node.rs 77.05% <71.42%> (-3.19%) ⬇️
src/commands.rs 95.62% <100.00%> (-0.01%) ⬇️
src/ivalue_manager.rs 90.02% <100.00%> (-0.05%) ⬇️
src/manager.rs 87.59% <100.00%> (+0.80%) ⬆️
src/redisjson.rs 82.55% <100.00%> (+1.34%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

oshadmi
oshadmi previously approved these changes Nov 9, 2022
Copy link
Collaborator

@oshadmi oshadmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@rafie rafie marked this pull request as draft November 13, 2022 10:31
@gkorland gkorland marked this pull request as ready for review November 13, 2022 13:35
@oshadmi oshadmi self-requested a review December 19, 2022 17:48
oshadmi
oshadmi previously approved these changes Dec 19, 2022
Copy link
Collaborator

@oshadmi oshadmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@gkorland gkorland merged commit 9b39a0c into master Dec 20, 2022
@gkorland gkorland deleted the gkorland-clean-clippy-warnings branch December 20, 2022 11:43
rafie pushed a commit that referenced this pull request Dec 27, 2022
* clean clippy warnings

* revert so we can build with Rust 1.60

(cherry picked from commit 9b39a0c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants