Skip to content

Comments

MOD-4431: Allow repetition of filter relation instead of optional#850

Merged
oshadmi merged 1 commit intomasterfrom
omer_fix_jsonpath_filter_expr
Nov 6, 2022
Merged

MOD-4431: Allow repetition of filter relation instead of optional#850
oshadmi merged 1 commit intomasterfrom
omer_fix_jsonpath_filter_expr

Conversation

@oshadmi
Copy link
Collaborator

@oshadmi oshadmi commented Nov 4, 2022

Fix #614

Initial fix was done by #699 and this is a completion fix for compilation failure of a path such as

"$.friends[?(@.id >= 2 || @.id == 4 || @.id == 6)].name"

With an error such as

"\"$.friends[?(@.id >= 2 || @.id ==  ---->>>> 4 || @.id == 6)].name\", expected one of the following: from_current, from_root." }'

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Base: 80.42% // Head: 80.42% // No change to project coverage 👍

Coverage data is based on head (3b3f0e4) compared to base (8ab16af).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #850   +/-   ##
=======================================
  Coverage   80.42%   80.42%           
=======================================
  Files          14       14           
  Lines        3857     3857           
=======================================
  Hits         3102     3102           
  Misses        755      755           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@oshadmi oshadmi merged commit ce225df into master Nov 6, 2022
@oshadmi oshadmi deleted the omer_fix_jsonpath_filter_expr branch November 6, 2022 09:17
oshadmi added a commit that referenced this pull request Nov 6, 2022
oshadmi added a commit that referenced this pull request Nov 6, 2022
[2.4] Allow repetition of filter relation instead of optional (#850)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JSON.GET path syntax has an issue with filtering using an OR condition when encountering non-existent values

2 participants