Conversation
| //////////////////////////////////////////////////////////// | ||
| struct FilesDropped | ||
| { | ||
| std::vector<String> filenames; //!< Files which were dropped |
There was a problem hiding this comment.
why isn't it a std filesystem path?
There was a problem hiding this comment.
Presumably just because this was originally targeting SFML 2
|
Tested on Ubuntu 25.10 on Wayland, seems to work fine but it also seems like it shouldn't work as I'm getting an error saying it is not supported on XWayland... 
Other than that I think this is a great feature though I'm curious why is this planned for SFML 3.2 and not 3.1? |
I'd like to release 3.1 soon and event/input/window improvements will be the primary focus of SFML 3.2. |
|
I've rebased onto latest master and removed the xwayland check - I guess it was working without the x11 window atom being set, but comments indicate it may crash, so curious if you can test that. If it does still crash then I can add the check again but without the error message |
Rebased #2265 on latest master and addressed only outstanding review point I could see (removing some commented out code that I assume was left from earlier testing)
Updated the event handling example to be able to test this event
Have tested on mac and windows, but don't have access to a linux machine with a GUI
closes #3565
Tasks
How to test this PR?
Run the event handling example and drop some files into the window - the file path(s) will be shown in the log