Webpages: Improve screen reader navigation experience#8663
Open
DNin01 wants to merge 10 commits intoScratchAddons:masterfrom
Open
Webpages: Improve screen reader navigation experience#8663DNin01 wants to merge 10 commits intoScratchAddons:masterfrom
DNin01 wants to merge 10 commits intoScratchAddons:masterfrom
Conversation
DNin01
commented
Oct 23, 2025
Member
Author
DNin01
left a comment
There was a problem hiding this comment.
Some things to consider…
| "description": "A label used by screen readers." | ||
| }, | ||
| "enabledAddon": { | ||
| "message": "$1, add-on, on", |
Member
Author
There was a problem hiding this comment.
Why did I write the string like this?
- Some synthesizers mispronounce "addon" and it is technically a contraction of the full word "add-on", so that was used here.
- We usually refer to an addon's state as either "enabled" or "disabled", but Windows Narrator uses the term "disabled" to indicate a grayed-out control, so for distinction, I used "on" and "off" here.
| src="../../images/icons/help.svg" | ||
| class="icon-type setting-help-icon" | ||
| tabindex="-1" | ||
| :aria-labelledby="'setting-description-' + setting.id" |
Member
Author
There was a problem hiding this comment.
Here we have a graphic (image) whose label—alt text, essentially—is the full description of the setting. Is that right?
Samq64
reviewed
Oct 25, 2025
Member
|
Great work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
These changes are the start of improvements to screen reader accessibility.
Screen reader users will notice the following enhancements:
Let me know if I missed anything.
Commit summary
searchMsg.Tests
Tested with: