Performance improvements#1181
Merged
wongzigii merged 9 commits intoSwiftyJSON:masterfrom May 27, 2025
Merged
Conversation
Around 10% better performance on tests, 20% on "real-world" usage.
Around 8% better on tests.
…of closure in map function
Member
|
This looks great. |
Member
Contributor
Author
|
Tests pass successfully https://github.com/b5i/SwiftyJSON/actions/runs/15269527270/job/42941610613. Performance improvements are visible (5.06s vs 6.52s -> 23% faster). |
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! Here's a few simple optimizations for the project (around 16% faster tests and 25% faster in my use case), I tried to remove closure when they weren't needed, and use the new dictionary APIs from Swift 4 to improve the speed of the module.
Let me know what you think!