Add Swift 6 support with Sendable conformance#1190
Merged
wongzigii merged 3 commits intoSwiftyJSON:masterfrom Feb 4, 2026
Merged
Add Swift 6 support with Sendable conformance#1190wongzigii merged 3 commits intoSwiftyJSON:masterfrom
wongzigii merged 3 commits intoSwiftyJSON:masterfrom
Conversation
- Update Package.swift to swift-tools-version:6.0 - Remove swiftLanguageVersions lock - Add @unchecked Sendable to JSON struct - Add Sendable to Type, SwiftyJSONError, JSONKey enums - Add comprehensive concurrency tests (18 tests) - Update README requirements and CHANGELOG The JSON type can now safely cross actor boundaries in Swift 6 concurrency. Closes SwiftyJSON#1163
Each test now directly corresponds to a type made Sendable: - testJSONSendable: JSON crosses actor boundary - testTypeSendable: Type enum crosses actor boundary - testSwiftyJSONErrorSendable: SwiftyJSONError crosses actor boundary Removed redundant tests that proved the same thing in different ways (TaskGroup, Task.detached, MainActor variations). Added missing coverage for Type enum Sendable conformance.
Member
|
LGTM! thanks @lex00 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add Swift 6 support with full
Sendableconformance for theJSONtype, addressing #1163.Changes
@unchecked SendableconformanceSendableconformanceSendableconformanceSendableconformanceWhy
@unchecked Sendable?The
JSONstruct stores values in[Any]and[String: Any]properties, which the compiler cannot verify as Sendable. However,@unchecked Sendableis safe because:JSONis a value type with value semanticsTesting
testJSONSendable: JSON crosses actor boundarytestTypeSendable: Type enum crosses actor boundarytestSwiftyJSONErrorSendable: SwiftyJSONError crosses actor boundaryTotal: 149 tests passing with zero warnings.
Checklist
Closes #1163