Skip to content

Comments

Add directional editor moving bindings#61

Merged
marcoieni merged 1 commit intoVSpaceCode:developfrom
joelpet:patch-1
Jun 28, 2020
Merged

Add directional editor moving bindings#61
marcoieni merged 1 commit intoVSpaceCode:developfrom
joelpet:patch-1

Conversation

@joelpet
Copy link
Contributor

@joelpet joelpet commented Jun 25, 2020

This is a suggestion to add bindings similar to <SPC w H/J/K/L> for moving the active editor into other editor groups.

@stevenguh
Copy link
Member

Ah, so this is similar with the pre v0.4.0 window moving or the overrides described quick editor move in the README https://github.com/VSpaceCode/VSpaceCode#quick-editor-move. I like this change since it's related to the active editor (buffer), however, since it doesn't exists in spacemacs. I would like to hear other's opinion on this.

@marcoieni, what do you think?

@marcoieni
Copy link
Member

This is awesome.
Since this pr is against the master branch maybe we should accept it with the new release in order to avoid conflicts with develop branch.

marcoieni added a commit that referenced this pull request Jun 26, 2020
These key bindings where proposed in pull request #61.
I add them to the vscode-vim branch, too.
@stevenguh
Copy link
Member

stevenguh commented Jun 28, 2020

Thanks @joelpet Can you add the change to the CHANGLOG and change the merging branch to develop? I kind of want to release this with v0.5.0. I think v0.5.0 is very close to release.

Add bindings for moving the active editor into other editor groups, either above, below, to its left, or to its right.
@joelpet joelpet changed the base branch from master to develop June 28, 2020 09:11
@marcoieni
Copy link
Member

I didn't know you can change branches, nice.
Anyway, maybe "Move Editor to X Group" is better than "Move Editor into X Group". What do you think?

@joelpet
Copy link
Contributor Author

joelpet commented Jun 28, 2020

Anyway, maybe "Move Editor to X Group" is better than "Move Editor into X Group". What do you think?

I used the title that's shown in the Ctrl + Shift + P menu to stay consistent with vscode terminology. It's your call as a maintainer though, so let me know if you'd like me to change. :)

@marcoieni marcoieni merged commit a1e8d6d into VSpaceCode:develop Jun 28, 2020
@marcoieni
Copy link
Member

Ok, I accepted your PR 😄

Thank you so much for contributing to VSpaceCode 🚀

@joelpet
Copy link
Contributor Author

joelpet commented Jun 28, 2020

Thank you so much for contributing to VSpaceCode rocket

No problem. Thank you for building and maintaining it! 🚀

@joelpet joelpet deleted the patch-1 branch June 28, 2020 10:36
stevenguh pushed a commit that referenced this pull request Jun 29, 2020
Add bindings for moving the active editor into other editor groups, either above, below, to its left, or to its right.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants