feat: optimize orphan files cleaner #135
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
+1 |
lucasfang
previously approved these changes
Feb 11, 2026
There was a problem hiding this comment.
Pull request overview
This PR improves the performance of orphan file cleaning by parallelizing snapshot/manifest scanning when computing the set of “used” files (linked to #134).
Changes:
- Parallelize
OrphanFilesCleanerImpl::GetUsedFiles()by dispatching per-snapshot work to the configuredExecutor. - Factor snapshot-specific logic into a new helper
GetUsedFilesBySnapshot. - Add a new clean metric key (
snapshotFiles) and record the snapshot count.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/paimon/core/operation/orphan_files_cleaner_impl.h |
Declares new helper for per-snapshot used-file collection. |
src/paimon/core/operation/orphan_files_cleaner_impl.cpp |
Implements concurrent per-snapshot scanning and aggregates results; emits new metric. |
src/paimon/core/operation/metrics/clean_metrics.h |
Adds CLEAN_SNAPSHOT_FILES metric key. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
917e6a6 to
e550479
Compare
8591eed to
da24dc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #134
Concurrent reading of snapshot files to obtain used files
Tests
No.
API and Format
No.
Documentation
No.