Conversation
… guards Once a `Route` matches via the `match` or `path` property, we need to immediately create the injector for the route (if it has providers) before running the `CanMatch` guards. This is necessary because the `CanMatch` guards might be provided in the `Route` providers. Fixes angular#46386
6e3087e to
f8d28a3
Compare
AndrewKushnir
approved these changes
Jun 16, 2022
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
LGMT, just a small comment to add a couple sentences to the public API symbol.
AndrewKushnir
approved these changes
Jun 16, 2022
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
f8d28a3 to
83e4a22
Compare
The `CanMatchFn` is already exposed in the type signature for `canMatch` on the `Route`. This function type should already be exposed as public API but was missed in the initial implementation because the older guards use the `any` type instead.
83e4a22 to
af1e85a
Compare
Contributor
|
This PR was merged into the repository by commit f94c6f4. |
AndrewKushnir
pushed a commit
that referenced
this pull request
Jun 17, 2022
The `CanMatchFn` is already exposed in the type signature for `canMatch` on the `Route`. This function type should already be exposed as public API but was missed in the initial implementation because the older guards use the `any` type instead. PR Close #46394
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 1
fix(router): Ensure Route injector is created before running CanMatch guards
Once a
Routematches via thematchorpathproperty, we need toimmediately create the injector for the route (if it has providers)
before running the
CanMatchguards. This is necessary because theCanMatchguards might be provided in theRouteproviders.Fixes #46386
Commit 2
fix(router): Expose CanMatchFn as public API
The
CanMatchFnis already exposed in the type signature forcanMatchon theRoute. This function type should already be exposed as public API but wasmissed in the initial implementation because the older guards use the
anytypeinstead.