fix(core): make parent injector argument required in createEnvironmentInjector#46397
Closed
AndrewKushnir wants to merge 1 commit intoangular:mainfrom
Closed
fix(core): make parent injector argument required in createEnvironmentInjector#46397AndrewKushnir wants to merge 1 commit intoangular:mainfrom
createEnvironmentInjector#46397AndrewKushnir wants to merge 1 commit intoangular:mainfrom
Conversation
atscott
approved these changes
Jun 16, 2022
Contributor
atscott
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
13bacde to
5e30ac4
Compare
alxhub
approved these changes
Jun 16, 2022
Contributor
Author
atscott
reviewed
Jun 16, 2022
…ntInjector` Previously, the `createEnvironmentInjector` function allowed creating an instance of an EnvironmentInjector without providing a parent injector. This resulted in an injector instance, which was detached from the DI tree, thus having limited value. This commit updates the types of the `createEnvironmentInjector` function to make the parent injector a required argument.
5e30ac4 to
e5ccc04
Compare
alxhub
approved these changes
Jun 16, 2022
pkozlowski-opensource
approved these changes
Jun 17, 2022
Member
pkozlowski-opensource
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: public-api
Contributor
Author
|
This PR was merged into the repository by commit bb7c804. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the
createEnvironmentInjectorfunction allowed creating an instance of an EnvironmentInjector without providing a parent injector. This resulted in an injector instance, which was detached from the DI tree, thus having limited value. This commit updates the types of thecreateEnvironmentInjectorfunction to make the parent injector a required argument.PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
createEnvironmentInjectorAPI is in the Developer Preview phase (and it's marked as such), so this change can be included into the patch branch.