fix(router): allow to return UrlTree from CanMatchFn#46455
Closed
dimakuba wants to merge 1 commit intoangular:mainfrom
Closed
fix(router): allow to return UrlTree from CanMatchFn#46455dimakuba wants to merge 1 commit intoangular:mainfrom
UrlTree from CanMatchFn#46455dimakuba wants to merge 1 commit intoangular:mainfrom
Conversation
Currently it's not possible to return plain `UrlTree` from `CanMatchFn`, only wrapped `UrlTree` into Observable or Promise is allowed. These changes allow to return `UrlTree` from `CanMatchFn`.
atscott
approved these changes
Jun 22, 2022
Contributor
atscott
left a comment
There was a problem hiding this comment.
reviewed-for: fw-router
reviewed-for: public-api
AndrewKushnir
approved these changes
Jun 22, 2022
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
jessicajaniuk
approved these changes
Jun 22, 2022
Contributor
jessicajaniuk
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
Contributor
|
This PR was merged into the repository by commit abe3759. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently it's not possible to return plain
UrlTreefromCanMatchFn,only wrapped
UrlTreeinto Observable or Promise is allowed.These changes allow to return
UrlTreefromCanMatchFn.