fix(core): remove @internal annotation from ApplicationRef.injector#46727
Closed
arturovt wants to merge 1 commit intoangular:mainfrom
Closed
fix(core): remove @internal annotation from ApplicationRef.injector#46727arturovt wants to merge 1 commit intoangular:mainfrom
@internal annotation from ApplicationRef.injector#46727arturovt wants to merge 1 commit intoangular:mainfrom
Conversation
The `injector` getter is annotated with `@internal` and is removed from declarations. This commit removes the annotation thus it's possible to access the `injector` on the `ApplicationRef`, e.g., after calling `bootstrapApplication`.
Member
|
Thnx, but we are going to go with #46665 instead |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
injectorgetter is annotated with@internaland is removed from declarations.This commit removes the annotation thus it's possible to access the
injectoron theApplicationRef, e.g., after callingbootstrapApplication.Currently, it requires casting
ApplicationRefto{ injector: Injector }after calling thebootstrapApplication, e.g.:NgModuleRefprior toApplicationRefhas a publicinjectorproperty which allows the above behavior:This change also allows a more straightforward setup for micro-frontend adapters (e.g., single-spa-angular). The micro-frontend bootstrap function can resolve to
ApplicationRef | NgModuleRef<T>; they both have thedestroymethod now, and havinginjectoron both types doesn't require type cast forApplicationRef.